Move some project routes under /-/ scope
What does this MR do?
Just to see how many tests will fail.
Affected routes:
project/-/network
project/-/branches
project/-/tags
project/-/graphs
project/-/protected_branches
project/-/protected_tags
-
project/-/settings
and all routes under it
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.0
added backstage [DEPRECATED] label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Małgorzata Ksionek ( @mksionek
)Robert Speicher ( @rspeicher
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 27 commits
-
79281964...f1456594 - 26 commits from branch
master
- 4e6038cb - Move some project routes under /-/ scope
-
79281964...f1456594 - 26 commits from branch
I tried to move whole
repository
andwiki
blocks but it failed too many specs. I think the better approach is move "safe" routes first likegraphs
,branches
etc.Edited by Dmytro Zaporozhets (DZ)added backend label
Failure is not related: https://gitlab.com/gitlab-org/gitlab-ce/issues/62021
@stanhu I was inspired by https://gitlab.com/gitlab-org/gitlab-ce/issues/61985 and decided to move some project routes under
/-/
. What do you think? I suggest we create a technical issue for that and plan to have every project (and group) route under/-/
scope. It should simplify routing for Rails and make our application more consistent from URL building perspective.Edited by Dmytro Zaporozhets (DZ)- Resolved by Stan Hu
@dzaporozhets I like it, thanks! My only question is: is this going to break any applications or bookmarks that depend on the legacy routes? I can see the
/settings
or/branches
route as potentially an issue, but I'm not sure. Ah, I see you have redirections in place to mitigate this. Great.Edited by Stan Hu
- Resolved by Ash McKenzie
May I humbly request that either in this MR or a follow up MR we document the intent and purpose of the
/-/
namespace, especially for newcomers? Even a small comment would help!
mentioned in merge request !28533 (merged)
mentioned in issue #62083 (moved)
assigned to @stanhu
unassigned @dzaporozhets
added deprecation label
mentioned in commit 4edfa510
@dzaporozhets Great, thanks! Looks good to me.
- Resolved by Dmytro Zaporozhets (DZ)
Am seeing failures https://gitlab.com/gitlab-org/gitlab-ee/pipelines/62501933 relating to this MR.. working through the fixes now.
mentioned in merge request !28717 (merged)
mentioned in merge request !28830 (merged)
mentioned in issue gitlab-org/release/tasks#800 (closed)
mentioned in issue #63398 (moved)
For gitlab#29572
mentioned in issue gitlab#28848 (closed)
added routing label
mentioned in merge request gitlab!26808 (merged)
mentioned in issue gitlab#216334 (closed)
mentioned in issue gitlab#29572