Skip to content

Fix hiding of quick action prompt in specs

Heinrich Lee Yu requested to merge fix-slow-preview-note-specs into master

What does this MR do?

I noticed that our quick actions specs were running slower than usual:

https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/211198630

https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/211198631

I ran the specs with CHROME_HEADLESS=no to see what was happening.

Apparently, it's waiting during preview note specs for the Capybara timeout

This MR fixes this and reduces execution time of these 2 specs from ~2000 seconds each to ~800 seconds each.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports