Skip to content

fix(favicon): crossorigin is required to create overlay images

Roger Meier requested to merge siemens/gitlab-ce:fix/crossorigin into master

What does this MR do?

canvas.crossOrigin = 'anonymous'; is required to execute a canvas.toDataURL();

A very good explanation can be found here: https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image

Sentry Crash Report:

Screenshot_2019-05-13_at_06.58.50

First proposal to fix this has been made here

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Roger Meier

Merge request reports