Skip to content

Rename methods that conflict in Rails 5.2

Heinrich Lee Yu requested to merge 55583-rename-method-conflicts into master

What does this MR do?

  1. Add suffix to Ci::JobArtifact's file_format enum

  2. Rename GroupMember.in_groups to GroupMember.of_groups

  3. Event#destroyed? causes problems so this is renamed to destroyed_action?. Other related methods are also renamed to add _action for consistency.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #55583 (closed)

Edited by Heinrich Lee Yu

Merge request reports