Rename methods that conflict in Rails 5.2
What does this MR do?
-
Add suffix to
Ci::JobArtifact
'sfile_format
enum -
Rename
GroupMember.in_groups
toGroupMember.of_groups
-
Event#destroyed?
causes problems so this is renamed todestroyed_action?
. Other related methods are also renamed to add_action
for consistency.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #55583 (closed)
Edited by Heinrich Lee Yu