Skip to content

Docs: couple of improvements to the Vuex frontend guide

Phillip Johnsen requested to merge phillipj/gitlab-ce:patch-55 into master

What does this MR do?

First of all, thanks for the great documentation and guide you've written for using Vuex 👍 Easy to follow and stuffed with good practises.

Here's two nitpick improvements to the following:

  • set state.isAddingUser = false when request resulted in an error, as the request has finished after all
  • be very explicit about vuex store being a local module to avoid confusion about a dependency named store

Author's checklist

  • Follow the Documentation Guidelines and Style Guide.
  • Link docs to and from the higher-level index page, plus other related docs where helpful. -- not relevant
  • Apply the ~Documentation label.

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set and that you merge the equivalent EE MR before the CE MR if both exist.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Phillip Johnsen

Merge request reports