Skip to content

Use NotesFinder to get Noteable

Patrick Derichs requested to merge pderichs-52123 into master

What does this MR do?

One step towards #52123 (closed)

Uses NotesFinder.target to find Noteable within lib/api/notes.rb.

EE part: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13265

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Derichs

Merge request reports