Skip to content

#61441 Allow user to set email ID before setting up 2FA

Kartikey Tanna requested to merge tannakartikey/gitlab-ce:61441 into master

What does this MR do?

The MR is to resolve the issue #61441 (moved).

It checks that if the user has temporary email ID assigned or not. If the temporary email ID is assigned then it bypasses the two-factor requirement check. That will allow users to associate email ID first with their account and it will not go in continuous redirect scenario as explained in #61441 (moved)

There are no tests added yet. I read somewhere in the docs to start a PR as early as possible. That is why doing it right away to confirm that I am on the right path.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kartikey Tanna

Merge request reports