Skip to content

Use Environment#deployment_platform method instead

Thong Kuah requested to merge environment_terminal_methods into master

What does this MR do?

Use Environment#deployment_platform for inside both has_terminals? and terminals.

Background

In https://gitlab.com/gitlab-org/gitlab-ee/commit/0ab64ac7c055e5382b3d865e025969325dd6dda0, EE was diverged from CE to use Environment#deployment_platform - at this time Environment#deployment_platform had divergent implementations. Later, in 45d99c92, EE and CE's Environment#deployment_platform was synchronised.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports