Skip to content

Resolve "Style secondary button type to be aligned with pattern library"

What does this MR do?

Based on issue #61144 (closed)

Brings the styling of outline buttons up to design standards.

Does not adjust border width or padding (that will be handled separately).

Variant Default Hover Focus Active
Info Screen_Shot_2019-05-22_at_3.50.15_PM Screen_Shot_2019-05-22_at_3.50.31_PM Screen_Shot_2019-05-22_at_3.50.41_PM Screen_Shot_2019-05-22_at_3.50.57_PM
Success Screen_Shot_2019-05-22_at_3.51.13_PM Screen_Shot_2019-05-22_at_3.51.23_PM Screen_Shot_2019-05-22_at_3.51.35_PM Screen_Shot_2019-05-22_at_3.51.53_PM
Warning Screen_Shot_2019-05-22_at_4.25.08_PM Screen_Shot_2019-05-22_at_4.25.18_PM Screen_Shot_2019-05-22_at_4.25.31_PM Screen_Shot_2019-05-22_at_4.25.40_PM
Danger Screen_Shot_2019-05-22_at_3.52.07_PM Screen_Shot_2019-05-22_at_4.24.32_PM Screen_Shot_2019-05-22_at_4.24.41_PM Screen_Shot_2019-05-22_at_4.24.50_PM
Split Dropdown Left Screen_Shot_2019-05-22_at_4.26.03_PM Screen_Shot_2019-05-22_at_4.26.21_PM Screen_Shot_2019-05-22_at_4.26.32_PM Screen_Shot_2019-05-22_at_4.26.43_PM
Split Dropdown Right Screen_Shot_2019-05-22_at_4.26.03_PM Screen_Shot_2019-05-22_at_4.26.55_PM Screen_Shot_2019-05-22_at_4.27.04_PM Screen_Shot_2019-05-22_at_4.27.12_PM
Dropdown Screen_Shot_2019-05-23_at_8.36.44_AM Screen_Shot_2019-05-23_at_8.36.54_AM Screen_Shot_2019-05-23_at_8.37.03_AM Screen_Shot_2019-05-23_at_8.37.12_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Scott Hampton

Merge request reports