Skip to content

Resolve "Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/commits.scss`"

What does this MR do?

This MR fixes the stylelint errors for commits.scss.

Some classes were either not used (.notes_count, .commited_ago) or in the wrong format (.generic_commit_status -> .generic-commit-status).

Other classes were unnecessary and were replaced by utility classes.

Below are some screenshots of before and after, but the results look the same because no styling was changed just how it was implemented.

There is an EE backport where there was also a wrongly formatted class (.project_namespace): https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/11902

Commits Commit Description Commit Component
before Screen_Shot_2019-04-26_at_2.06.55_PM Screen_Shot_2019-04-26_at_2.07.13_PM Screen_Shot_2019-04-26_at_2.07.33_PM
after Screen_Shot_2019-04-26_at_2.15.45_PM Screen_Shot_2019-04-26_at_2.16.15_PM Screen_Shot_2019-04-26_at_2.15.20_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #59898 (closed)

Edited by Scott Hampton

Merge request reports