Skip to content

Extract ProjectStatistics updates into a concern

Alessio Caiazza requested to merge ac-refactor-project-stats into master

What does this MR do?

This MR is extracting refactoring from !27373 (merged) for an easier review.

Both Ci::Build and Ci::JobArtifact are implementing the same logic to invoke ProjectStatistics.increment_statistic.

This MR extracts such duplicated logic into the new UpdateProjectStatistics concern. Also duplicated tests are extracted into shared examples.

In order to show group level storage counters (#59232 (closed)), we need to keep track of storage used for the Package features, and it's time to fix this duplication.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alessio Caiazza

Merge request reports