Only show author in autocomplete dropdown if author is active
What does this MR do?
Currently, the assignee dropdown shows the issue/MR author as a choice even if their state is non-active (i.e. blocked
, ldap_blocked
). This bug was reported by a customer (Zendesk, internal use).
This MR adds a check to make sure the author is active before added it to the returned JSON.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Wei-Meng Lee