Only check abilities on rendered GraphQL nodes
What does this MR do?
Instead of checking abilities on all nodes in a GraphQL connection, we only check the ones that are being rendered. Normally, the user should have access to all the allowed objects. But we do validate this on the GraphQL type as that could be used in places where the object loaded is not authorized.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
- [-] Code review guidelines
-
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60355 and https://gitlab.com/gitlab-org/gitlab-ce/issues/58647
Edited by Luke Duncalfe