Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !27273

Only check abilities on rendered GraphQL nodes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bob Van Landuyt requested to merge reprazent/gitlab-ce:bvl-graphql-only-authorize-rendered-fields into master Apr 11, 2019
  • Overview 39
  • Commits 1
  • Pipelines 10
  • Changes 9

What does this MR do?

Instead of checking abilities on all nodes in a GraphQL connection, we only check the ones that are being rendered. Normally, the user should have access to all the allowed objects. But we do validate this on the GraphQL type as that could be used in places where the object loaded is not authorized.

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • [-] Documentation created/updated or follow-up review issue created
  • [-] Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60355 and https://gitlab.com/gitlab-org/gitlab-ce/issues/58647

Edited Apr 17, 2019 by Luke Duncalfe
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bvl-graphql-only-authorize-rendered-fields