Skip to content

Refactor cluster application services

Thong Kuah requested to merge refactor_cluster_application_services into master

What does this MR do?

  • Refactor services to be more generic so that we can remove the duplication in the next step.
  • Stop rescuing errors from app.make_scheduled!

Any errors arising from app.make_scheduled! is un-expected and we should not hide the error.

Also we currently have to have #make_update_errored just solely to be able to transition from scheduled to update_errored in the case of a update, vs #make_errored in the case of a install. It will be great to be able to remove this distinction.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports