Skip to content

Handle possible HTTP exception for Sentry client

What does this MR do?

Prior this commit exceptions raised during a HTTP request weren't caught by the Sentry client and were passed to the user.

In addition the Sentry client tried to catch a non-existent error Sentry::Client::SentryError.

Now, the Sentry client catches all possible errors coming from a HTTP request.

See also a Sentry error (internal) and https://gitlab.com/gitlab-org/gitlab-ce/issues/60149

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #60149 (closed)

Edited by Michael Kozono

Merge request reports