Fall back to project repository type by default
requested to merge reprazent/gitlab-ce:bvl-fix-git-pull-repo-when-project-does-not-exist into master
What does this MR do?
This makes sure that we always have a repository type when trying to parse a repository from a path.
This is needed because sometimes we want to perform access checks as if the project already existed, for example when creating a project on push.
Before this we were only doing that when accessing git over http, this makes sure it also works correctly when accessing git over SSH
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team