Skip to content

Do not inherit when calling const_get

Thong Kuah requested to merge 59719-const-get into master

What does this MR do?

Fixes the case encountered in https://gitlab.com/gitlab-org/gitlab-ce/issues/59719 for app/models/concerns/prometheus_adapter.rb

When calling const_get, do not inherit, aka set false for the second argument.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

#59719 (moved)

Edited by Thong Kuah

Merge request reports