Skip to content

Fix vue render error for IDE status bar

Paul Slaughter requested to merge 59995-ide-status-bar-vue-render-error into master

What does this MR do?

When opening the IDE and there is no pipeline for the current branch, there is a Vue warning that ide_status_bar sent a Boolean to a String property (img-src). This also triggers a render error.

What was the fix?

Currently, state.latestPipeline can be one of the following values:

Value Usage
null The pipeline hasn't loaded yet (set in state.js)
false The pipeline has loaded, but nothing was returned.
Object The piepline has loaded.

Giving a semantic meaning to different falsey values hurts maintainability. This commit fixes the above problem by removing the false value and introducing a hasLoadedPipeline state property.

Screenshots

Before After
Screen_Shot_2019-04-04_at_3.46.06_AM Screen_Shot_2019-04-04_at_3.14.57_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Closes #59995 (closed)

Edited by Paul Slaughter

Merge request reports