Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !26905

Merged
Created Apr 03, 2019 by Kamil Trzciński@ayufan🔴Maintainer7 of 7 tasks completed7/7 tasks

Allow to use untrusted ruby syntax

  • Overview 47
  • Commits 1
  • Pipelines 8
  • Changes 9

What does this MR do?

Brings an optional administratively controlled backward compatibility to use unsafe Ruby Regexp with only: and refs:.

This also brings back the compatibility for: // =~ 'aa' which become broken due to PATTERN.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/59703.

The EE version: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10566

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Style guides

Performance and testing

  • Tests added for this feature/bug

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Apr 04, 2019 by Kamil Trzciński
Assignee
Assign to
Reviewer
Request review from
11.10
Milestone
11.10 (Past due)
Assign milestone
Time tracking
Source branch: allow-to-use-untrusted-ruby-syntax