Don't render artifact download links for builds with expired artifacts
What does this MR do?
This changes the behavior of Pipeline#latest_builds_with_artifacts to not return builds if the previously existed artifacts have since expired. Currently, some pipelines will show download links for artifacts archives that no longer exist, but have some metadata recorded on the build record. Reproduction steps are in the linked issue below. There's a scope already built for Build that selects by artifacts_expire_at > Time.now, so we can use that instead of the simpler scope that detected for whether artifacts had existed.
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Edited by drew stachon