Skip to content

Reporting SSL certificate verify errors in CI external config

drew stachon requested to merge drew/gitlab-ce:ci-lint-ssl-error into master

What does this MR do?

The Config class currently catches several types of exceptions while processing external files, to which I'm adding OpenSSL errors. We currently crash hard if a config file is attempted to be fetched via SSL with a self-signed certificate. This MR changes the behavior to raise a ConfigError (caught and reportable in the UI) with the certificate verification error message. This approach is already implemented for several other exception types, and this MR doesn't introduce any new concepts in error handling here.

What are the relevant issue numbers?

#52810 (closed)

Does this MR meet the acceptance criteria?

Edited by Kamil Trzciński

Merge request reports