Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !26672

Resolve "Make quick action "commands applied" banner more useful"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged 🙈 jacopo beschi 🙉 requested to merge 56100-make-quick-action-commands-applied-banner-more-useful into master Mar 27, 2019
  • Overview 164
  • Commits 1
  • Pipelines 57
  • Changes 22

What does this MR do?

Extends the quick actions "commands applied" banner to show the quick action preview text, but with everything in past tense.

Also shows a custom message in case the command didn't apply successfully falling back to Commands did not apply when the custom message is not set.

Screenshots

successful command

Screenshot_2019-04-19_at_18.34.23

custom error message

Screenshot_2019-06-14_at_15.09.33

general error message

Screenshot_2019-06-14_at_18.13.19

multiple commands

Screenshot_2019-06-14_at_15.09.57

ee port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14630

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated via this MR
  • Documentation reviewed by technical writer or follow-up review issue created
  • Tests added for this feature/bug
  • Tested in all supported browsers
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides
  • Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] Security reports checked/validated by reviewer

Closes #56100 (closed)

Edited Jul 29, 2019 by Mayra Cabrera
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 56100-make-quick-action-commands-applied-banner-more-useful