Skip to content

Revert "Merge branch 'remove-unused-css-from-mr-24724' into 'master'"

Paul Slaughter requested to merge revert-0be93623 into master

What does this MR do?

The CSS class d-flex-center that was removed is actually used and helpful.

Please note!

Here is the corresponding EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10431 that reverts the EE changes.

Why was d-flex-center removed?

According to the commit message (https://gitlab.com/gitlab-org/gitlab-ce/commit/d030b0253d43b24991987b3dc149081f3b4dbbb7) it was incorrectly assumed that this is the same as BS4 align-items-center. This is not the case. d-flex-center is a helpful composite class of d-flex justify-content-center align-items-center. Without this, the vertical and horizontal alignment of some elements are off.

Without d-flex-center (on master) With d-flex-center
Screen_Shot_2019-03-26_at_11.00.51_AM Screen_Shot_2019-03-26_at_11.01.23_AM

This is also needed by some other MR's:

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports

Loading