Skip to content

Make the job#successful? method wait by refreshing

Dan Davison requested to merge qa-dd-improve-job-querying-successful into master

What does this MR do?

Improves the waiting of the Page::Project::Job::Show#successful? method.

Previously, there was simply a guard clause and some waiting.

This improvement will refresh the page every interval until the condition is met.

This can help edge cases, including https://gitlab.com/gitlab-org/quality/nightly/-/jobs/179955878 where a job is queued, but hasn't started. (build output hasn't appeared)

create_project_with_auto_devops_spec.rb_2019-03-19-05-03-56.769

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Merge request reports