Bring back Rugged implementation of commit_tree_entry
This brings back some of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20176/diffs.
We discovered another N+1 that hits Gitaly TreeEntry
via the RelativeLinkFilter
: https://gitlab.com/gitlab-org/gitlab-ce/issues/58657. When a blob is loaded with many relative links, TreeEntry
is called for each link to scan the URI type.
There are multiple paths that hit Gitaly TreeEntry
, and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25706 did not cover all
cases. This merge request covers another common use case.
For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged may be faster than going through than Gitaly. This merge request introduces
the feature flag rugged_commit_tree_entry
to activate the Rugged method.
Merge request reports
Activity
changed milestone to %11.9
added feature flag + 1 deleted label
added 1 commit
- ccc3927d - Bring back Rugged implementation of commit_tree_entry
1 Warning 4ee08fd1: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Heinrich Lee Yu ( @engwan
)Sean McGivern ( @smcgivern
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- de64482c - Bring back Rugged implementation of commit_tree_entry
@stanhu I think we ought to say a little more in the MR description than:
Full context is in Slack: https://gitlab.slack.com/archives/C6PUQFCUE/p1551933464019100
I scanned that slack thread and I see no reason why we can't explain the context without having to mention the customer.
- we discovered another N+1 that hits Gitaly TreeEntry (issue link?)
- there are multiple paths that hit Gitaly TreeEntry and our our previous rugged patch (MR link?) did not cover them all
- this MR extends the coverage of the rugged patch
Did I get that right?
- Resolved by Stan Hu
@stanhu I am pre-approving this hoping you will resolve the MR description issue.
assigned to @stanhu
added 1 commit
- 4ee08fd1 - Add back Rugged support for retrieving a commit tree entry
@jacobvosmaer-gitlab Yes, thanks. You are right. I've updated the merge request description to be clearer.
assigned to @DouweM
mentioned in commit 97357c5b