Skip to content
Snippets Groups Projects

Bring back Rugged implementation of commit_tree_entry

Merged Stan Hu requested to merge sh-rugged-commit-tree-entry into master

This brings back some of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20176/diffs.

We discovered another N+1 that hits Gitaly TreeEntry via the RelativeLinkFilter: https://gitlab.com/gitlab-org/gitlab-ce/issues/58657. When a blob is loaded with many relative links, TreeEntry is called for each link to scan the URI type.

There are multiple paths that hit Gitaly TreeEntry, and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25706 did not cover all cases. This merge request covers another common use case.

For users using Gitaly on top of NFS, accessing the Git data directly via Rugged may be faster than going through than Gitaly. This merge request introduces the feature flag rugged_commit_tree_entry to activate the Rugged method.

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jacob Vosmaer approved this merge request

    approved this merge request

  • @stanhu I am pre-approving this hoping you will resolve the MR description issue.

  • assigned to @stanhu

  • Stan Hu changed the description

    changed the description

  • Stan Hu added 1 commit

    added 1 commit

    • 4ee08fd1 - Add back Rugged support for retrieving a commit tree entry

    Compare with previous version

  • Author Owner

    @jacobvosmaer-gitlab Yes, thanks. You are right. I've updated the merge request description to be clearer.

  • Stan Hu resolved all discussions

    resolved all discussions

  • assigned to @DouweM

  • Douwe Maan approved this merge request

    approved this merge request

  • merged

  • Douwe Maan mentioned in commit 97357c5b

    mentioned in commit 97357c5b

  • Stan Hu added 1 deleted label

    added 1 deleted label

  • Please register or sign in to reply
    Loading