Handle transformed notes from polling response
What does this MR do?
Transforms notes when we receive a transformed note in the polling response
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
added Deliverable Plan [DEPRECATED] Product Vision FY20 backend depth devopsplan direction documentation frontend issues merge requests missed:11.8 ~2975006 workflowin review + 1 deleted label
removed backend label
@winh I found a problem while testing in staging. This transforms the note in the
UPDATE_NOTE
mutation if we get a transformed note during polling.Can you please review? Thanks
assigned to @winh
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend André Luís ( @andr3
)Filipa Lacerda ( @filipa
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Inactive Account
@engwan Do I understand it correctly that this is the frontend side of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25084/diffs?
Changes look good to me but I haven't tested this locally yet.
added 1 commit
- d72a61b4 - Handle transformed notes from polling response
@engwan No worries—thank you for jumping on the fix!
I will test this locally in a bit (roughly 2 hours from now) and then send to a frontend maintainer.
Sorry for the delay—tested locally and works as expected!
While testing I found https://gitlab.com/gitlab-org/gitlab-ce/issues/58587 which should be handled separately and is out of scope here.
@iamphill Can you please review / merge?
If you'd like to test this, you need to run
Feature.enable(:reply_to_individual_notes)
inbin/rails console
.assigned to @iamphill
mentioned in commit 08622a6e
mentioned in issue gl-retrospectives/plan#24 (closed)