Skip to content
Snippets Groups Projects

Handle transformed notes from polling response

Merged Heinrich Lee Yu requested to merge 30299-transform-notes-from-polling-response into master
All threads resolved!

What does this MR do?

Transforms notes when we receive a transformed note in the polling response

What are the relevant issue numbers?

#30299 (closed)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @engwan Do I understand it correctly that this is the frontend side of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25084/diffs?

    Changes look good to me but I haven't tested this locally yet.

  • Author Maintainer

    Yes, I forgot to test it properly and didn't notice the frontend didn't handle the transformation of an existing note.

    I guess I only tested with the case where the individual note was not yet loaded on the other tab.

  • added 1 commit

    • d72a61b4 - Handle transformed notes from polling response

    Compare with previous version

  • Inactive Account resolved all discussions

    resolved all discussions

  • @engwan No worries—thank you for jumping on the fix! :muscle:

    I will test this locally in a bit (roughly 2 hours from now) and then send to a frontend maintainer.

  • Heinrich Lee Yu resolved all discussions

    resolved all discussions

  • Sorry for the delay—tested locally and works as expected! :thumbsup:

    While testing I found https://gitlab.com/gitlab-org/gitlab-ce/issues/58587 which should be handled separately and is out of scope here.

  • Inactive Account approved this merge request

    approved this merge request

  • @iamphill Can you please review / merge?

    If you'd like to test this, you need to run Feature.enable(:reply_to_individual_notes) in bin/rails console.

  • merged

  • Phil Hughes mentioned in commit 08622a6e

    mentioned in commit 08622a6e

  • Please register or sign in to reply
    Loading