Significantly reduce N+1 queries in /api/v4/todos endpoint
By preloading associations and batching issuable metadata lookups, we can significantly cut the number of SQL queries needed to load the Todos API endpoint.
On GitLab.com, my own tests showed my user's SQL queries went from 365 to under 60 SQL queries.
Merge request reports
Activity
changed milestone to %11.9
added api bugperformance memory usage labels
added 1 commit
- dd6c37c5 - Reduce N+1 queries by batching issuable metadata lookups
1 Warning 
062efe4f: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Jarka Košanová ( @jarka)James Lopez ( @jameslopez)Generated by
Edited by 🤖 GitLab Bot 🤖added 1 commit
- f70530c8 - Fix issuable metadata not being calculated properly
added 1 commit
- 8c01818f - Rename preload_associations -> with_associations to avoid confusion
mentioned in issue #40378 (closed)
mentioned in commit 606ddbea
mentioned in commit 8fa8f733
mentioned in commit d13fcca2
mentioned in merge request !25729 (closed)
added 67 commits
-
8c01818f...7b4130d0 - 66 commits from branch
master - ea3aa03c - Significantly reduce N+1 queries in /api/v4/todos endpoint
-
8c01818f...7b4130d0 - 66 commits from branch
added 1 commit
- 570a13d4 - Significantly reduce N+1 queries in /api/v4/todos endpoint
assigned to @tkuah
