Removed reply button from non-discussion comments
What does this MR do?
Fixed a bug where non-discussion comments have reply buttons
Before | After |
---|---|
![]() |
![]() |
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
added Plan [DEPRECATED] frontend issues merge requests + 1 deleted label
Please add one of the following throughput labels: ~"bug", ~"feature", security, Community contribution, ~"backstage"
added backstage [DEPRECATED] label
assigned to @iamphill
@iamphill can you review?
@okoghenun Can we add tests please?
assigned to @okoghenun
@okoghenun Isn't that intended behavior?
From the description of https://gitlab.com/gitlab-org/gitlab-ce/issues/30299:
For existing discussions (whether one-comment discussions or multi-comment discussions):
- The reply button exists on the root comment. If you click it, the reply area comes into focused and you can type in it.
/cc @annabeldunstone
@okoghenun Yes, this is intended behavior! There should be a reply button on the root comment. This is mostly useful for when the discussion is collapsed.
Closing this MR because of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25519#note_145564003
added devopsplan label