Fixes transient failure in create_issue_spec.rb
What does this MR do?
Fixes transient failure in create_issue_spec.rb by using retry_on_expection
Also refactors retry_on_expection
into a separate module.
EE port MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9603
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/quality/nightly/issues/79
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated via this MR
- [-] Documentation reviewed by technical writer or follow-up review issue created
- [-] Tests added for this feature/bug
- [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
- [-] Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
- Resolved by Sanad Liaquat
- Resolved by Ramya Authappan
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer QA Mark Lapierre ( @mlapierre
)Generated by
DangerThe
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab-ce/pipelines/48129258 triggered https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/48131577 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/48131577 triggered https://gitlab.com/gitlab-org/gitlab-qa/pipelines/48135958 downstream.The
gitlab-qa
downstream pipeline passed.
marked the checklist item Conforms to the code review guidelines as completed
marked the checklist item Conforms to the merge request performance guidelines as completed
marked the checklist item Conforms to the style guides as completed
marked the checklist item Conforms to the database guides as completed
@at.ramya Could you review this and the EE port MR please? Thanks.
assigned to @at.ramya
mentioned in commit 61b606a8