Skip to content
Snippets Groups Projects

Fixes transient failure in create_issue_spec.rb

Merged Sanad Liaquat requested to merge qa-nightly-79-fix-create-issue-spec into master
All threads resolved!

What does this MR do?

Fixes transient failure in create_issue_spec.rb by using retry_on_expection Also refactors retry_on_expection into a separate module.

EE port MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9603

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/quality/nightly/issues/79

Does this MR meet the acceptance criteria?

Edited by Sanad Liaquat

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sanad Liaquat added 1 commit

    added 1 commit

    • 87026ee3 - Refactor select_*_filter methods

    Compare with previous version

  • Sanad Liaquat changed the description

    changed the description

  • Sanad Liaquat
  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    QA Mark Lapierre (@mlapierre)

    Generated by :no_entry_sign: Danger

  • Sanad Liaquat marked the checklist item Conforms to the code review guidelines as completed

    marked the checklist item Conforms to the code review guidelines as completed

  • Sanad Liaquat marked the checklist item Conforms to the merge request performance guidelines as completed

    marked the checklist item Conforms to the merge request performance guidelines as completed

  • Sanad Liaquat marked the checklist item Conforms to the style guides as completed

    marked the checklist item Conforms to the style guides as completed

  • Sanad Liaquat marked the checklist item Conforms to the database guides as completed

    marked the checklist item Conforms to the database guides as completed

  • Author Maintainer

    @at.ramya Could you review this and the EE port MR please? Thanks.

  • assigned to @at.ramya

  • Ramya Authappan resolved all discussions

    resolved all discussions

  • Ramya Authappan approved this merge request

    approved this merge request

  • Ramya Authappan resolved all discussions

    resolved all discussions

  • Ramya Authappan mentioned in commit 61b606a8

    mentioned in commit 61b606a8

  • Please register or sign in to reply
    Loading