Encode Content-Disposition filenames
Users downloading non-ASCII attachments would see garbled characters. When used with object storage, AWS S3 would return an InvalidArgument error: Header value cannot be represented using ISO-8859-1.
Per RFC 5987 and RFC 6266, Content-Disposition should be encoded
properly. This commit takes the Rails 6 implementation of
ActiveSuppport::Http::ContentDisposition
(https://github.com/rails/rails/pull/33829) and ports it here.
However, due to gitlab-workhorse#207 (closed),
the UTF-8 encoded Content-Disposition doesn't actually get sent to the user.
This MR at least fixes AWS S3 access.
Merge request reports
Activity
changed milestone to %11.8
added Plan [DEPRECATED] typebug labels
mentioned in issue #57033 (closed)
mentioned in issue gitlab-workhorse#207 (closed)
assigned to @smcgivern
-
@stanhu that's amazing, thanks! I didn't mean for you to take this, just to double-check my assumption.
assigned to @stanhu
assigned to @smcgivern
enabled an automatic merge when the pipeline for e6850f73 succeeds
mentioned in commit f04910f2
mentioned in commit gitlab-workhorse@54e87781
mentioned in merge request gitlab-workhorse!360 (merged)
mentioned in commit gitlab-workhorse@53967ccf
mentioned in commit gitlab-workhorse@43290940
mentioned in commit gitlab-workhorse@c3cf9c0f
mentioned in issue gitlab-org/release/tasks#669 (closed)
mentioned in issue #57660 (closed)
mentioned in commit 248ec6cd
mentioned in merge request !25214 (merged)
mentioned in commit 134420f2
added devopsplan label
