Skip to content
Snippets Groups Projects

Provide a performance bar link to the Jaeger UI

Merged Andrew Newdigate requested to merge an-peek-jaeger into master
All threads resolved!

What does this MR do?

Provide a performance bar link to the Jaeger UI

Untitled_2

:point_down:

image

Jaeger is a distributed tracing tool. This change adds a "Tracing" link to the performance bar to directly link to a current request in Jaeger.

This is useful for two reasons:

  1. It provides affordance to developers that the distributed tracing tool is available, so that it can quickly be discovered.
  2. It allows developers to quickly find a specific trace without having to manually navigate to a second user-interface.

When used alongside gitlab-development-kit!611 (merged)

Video demonstration: https://youtu.be/6QC9-kdb3MA

How does it work?

The URL of a distributed trace UI is configured via the GITLAB_TRACING_URL environment variable. This variable contains a template:

  • {{ correlation_id }} will expand to the current correlation ID
  • {{ service }} will expand to the current service name

When running Jaeger locally, the following URL can be used:

http://localhost:16686/search?service=%{service}}&tags=%7B"correlation_id"%3A"%{correlation_id}"%7D

This is configured automatically in the GDK in gitlab-development-kit!611 (merged).

This template URL will generate a URL which will find the relevant trace in Jaeger, given the service and the correlation id. This makes finding traces extremely simple for users, encouraging the adoption of the tool.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Grzegorz Bizon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @andrewn 2 nits :smile:. Other than that, LGTM!

  • assigned to @andrewn

  • added 1 commit

    • 1ccec166 - Apply suggestion to lib/gitlab/tracing.rb

    Compare with previous version

  • added 1 commit

    • abe15bbf - Provide a performance bar link to the Jaeger UI

    Compare with previous version

  • Andrew Newdigate changed milestone to %11.9

    changed milestone to %11.9

  • Thanks @reprazent

    @smcgivern I think you're pretty familiar with the performance bar, would you mind reviewing?

  • Andrew Newdigate changed the description

    changed the description

  • @smcgivern apologies for not spotting that you're out.

    @grzesiek Would you be able to review?

  • @andrewn I left just two minor comments. Awesome work!

  • assigned to @andrewn

  • added 1 commit

    • 48bcd524 - Provide a performance bar link to the Jaeger UI

    Compare with previous version

  • Thanks @grzesiek. Fixed and one style change proposal.

  • mentioned in issue #57454 (closed)

  • Grzegorz Bizon approved this merge request

    approved this merge request

  • Grzegorz Bizon marked the checklist item Conforms to the code review guidelines as completed

    marked the checklist item Conforms to the code review guidelines as completed

  • Grzegorz Bizon marked the checklist item Security reports checked/validated by reviewer as completed

    marked the checklist item Security reports checked/validated by reviewer as completed

  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • Grzegorz Bizon mentioned in commit 25af9032

    mentioned in commit 25af9032

  • That's great, thanks @andrewn!

  • Please register or sign in to reply
    Loading