Skip to content
Snippets Groups Projects

Add metadata about the GitLab server to GraphQL

Merged Nick Thomas requested to merge (removed):56809-graphql-version-api into master

What does this MR do?

Implements a "metadata" graphql resource that duplicates the REST /version endpoint, and transforms the latter into a graphql client for the former

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Related to #56809 (closed)

Edited by Nick Thomas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas added 1 commit

    added 1 commit

    • 8d02feb3 - Reimplement the REST /version API as a GraphQL query

    Compare with previous version

  • Nick Thomas added 1 commit

    added 1 commit

    • 6543a68e - Add metadata about the GitLab server to GraphQL

    Compare with previous version

  • Nick Thomas
  • Nick Thomas
  • assigned to @reprazent

  • @reprazent do you mind looking at this and adding your thoughts sometime? I guess I'm interested in the code itself, and also the idea of making this the recommended thing to do when creating overlap with some part of the REST API in graphql.

    If you can pass it to @DouweM after you're done for further comment, that'd be great. I don't think we should merge it right now, so it's WIPped.

    Is graphql still behind a feature flag? That would be one reason why we couldn't merge something like this in %11.8

  • Is graphql still behind a feature flag? That would be one reason why we couldn't merge something like this in %11.8

    It is, but it's enabled by default. I don't know if that's enough to be able to merge it. But we could have a dependent feature flag for these migrations?

  • I guess I'm interested in the code itself, and also the idea of making this the recommended thing to do when creating overlap with some part of the REST API in graphql.

    I love the idea of recommending this, but I guess we'd need to add some helpers to facilitate migrating before we do.

  • @DouweM What are your thoughts?

  • assigned to @DouweM

  • Nick Thomas added 51 commits

    added 51 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading