Skip to content
GitLab Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !24580

Moves domain setting to Clusters page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mayra Cabrera requested to merge 52363-ui-changes-to-cluster-and-ado-pages into master Jan 22, 2019
  • Overview 106
  • Commits 5
  • Pipelines 35
  • Changes 23

What does this MR do?

Moves 'domain' setting from Auto DevOps to Clusters page

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9373

What are the relevant issue numbers?

Related to #52363 (closed)

Screenshots

Cluster page

On CE

Without ingress With ingress
Screen_Shot_2019-02-05_at_4.08.40_PM Screen_Shot_2019-02-05_at_4.08.46_PM

On EE

Without ingress With ingress
Screen_Shot_2019-02-05_at_4.18.31_PM Screen_Shot_2019-02-05_at_4.18.25_PM

Auto DevOps Page

CE & EE
Screen_Shot_2019-02-05_at_1.09.37_PM

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated via this MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24740
  • Documentation reviewed by technical writer or follow-up review issue created
  • Tests added for this feature/bug
  • Tested in all supported browsers
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides
  • [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] Security reports checked/validated by reviewer

Backend To do

  • Add domain field to Clusters page
  • Change domain text if the Cluster has Ingress installed
  • Remove domain from Auto DevOps
  • Inject KUBE_INGRESS_HOSTNAME (along with AUTO_DEVOPS_DOMAIN) environment variable if present.
  • Migration
  • Fix QA https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/152347852
Edited Feb 06, 2019 by Ash McKenzie
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 52363-ui-changes-to-cluster-and-ado-pages