Moves domain setting to Clusters page (!24580) · Merge Requests · GitLab.org / GitLab FOSS

Moves domain setting to Clusters page

What does this MR do?

Moves 'domain' setting from Auto DevOps to Clusters page

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9373

What are the relevant issue numbers?

Related to #52363 (closed)

Screenshots

Cluster page

On CE

Without ingress	With ingress

On EE

Without ingress	With ingress

Auto DevOps Page

CE & EE

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Documentation created/updated via this MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24740
Documentation reviewed by technical writer or follow-up review issue created
Tests added for this feature/bug
Tested in all supported browsers
Conforms to the code review guidelines
Conforms to the merge request performance guidelines
Conforms to the style guides
Conforms to the database guides
[-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
[-] Security reports checked/validated by reviewer

Backend To do

Add domain field to Clusters page
Change domain text if the Cluster has Ingress installed
Remove domain from Auto DevOps
Inject KUBE_INGRESS_HOSTNAME (along with AUTO_DEVOPS_DOMAIN) environment variable if present.
Migration
Fix QA https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/152347852

## What does this MR do?

Moves 'domain' setting from Auto DevOps to Clusters page

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9373

## What are the relevant issue numbers?

Related to #52363

## Screenshots

### Cluster page

**On CE**

| Without ingress | With ingress |
| ------ | ------ |
| ![Screen_Shot_2019-02-05_at_4.08.40_PM](/uploads/ccc42f3b068529b2c4a370557857f866/Screen_Shot_2019-02-05_at_4.08.40_PM.png) | ![Screen_Shot_2019-02-05_at_4.08.46_PM](/uploads/971bb6e28485ce6cb6c23aee0148c3e8/Screen_Shot_2019-02-05_at_4.08.46_PM.png)

**On EE**

| Without ingress | With ingress |
| ------ | ------ |
| ![Screen_Shot_2019-02-05_at_4.18.31_PM](/uploads/7b78f4f5bd0f3f14206239528d1b139f/Screen_Shot_2019-02-05_at_4.18.31_PM.png)  | ![Screen_Shot_2019-02-05_at_4.18.25_PM](/uploads/efbc9543acf2b2605a09aa16db95b0a1/Screen_Shot_2019-02-05_at_4.18.25_PM.png) |

### Auto DevOps Page

| CE & EE | 
| ------ |
| ![Screen_Shot_2019-02-05_at_1.09.37_PM](/uploads/4705310f7f31849c49df553b23de90d6/Screen_Shot_2019-02-05_at_1.09.37_PM.png) |

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) via this MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24740
- [ ] Documentation reviewed by technical writer *or* follow-up review issue [created](https://gitlab.com/gitlab-org/gitlab-ce/issues/new?issuable_template=Doc%20Review)
- [x] [Tests added for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html)
- [x] Tested in [all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)
- [x] Conforms to the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [x] Conforms to the [merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conforms to the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] Conforms to the [database guides](https://docs.gitlab.com/ee/development/README.html#database-guides)
- [-] Link to e2e tests MR added if this MR has ~"Requires e2e tests" label. See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/test-engineering/).
- [-] Security reports checked/validated by reviewer

## Backend To do

* [x]  Add `domain` field to Clusters page
* [x]  Change domain text if the Cluster has Ingress installed
* [x]  Remove domain from Auto DevOps
* [x]  Inject `KUBE_INGRESS_HOSTNAME` (along with `AUTO_DEVOPS_DOMAIN`) environment variable if present.
* [x]  Migration
* [x]  Fix QA https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/152347852

Edited Feb 06, 2019 by Ash McKenzie