All review jobs should share the same only & except

What does this MR do?

review-build-cng is a dependency for review-deploy therefore they should share the same only and except. This was brought up in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24538#note_133783746

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56707

changed milestone to %11.8

added Quality ci-build labels

mentioned in merge request !24538 (merged)

@dbalexandre Please review? Thanks!

assigned to @dbalexandre

	1 Warning
	f2d1aad2: This commit’s subject line is acceptable, but please try to reduce it to 50 characters.

Generated by Danger

Thanks for jumping into this @godfat! I was planning to fix this using review-base like the following but the approach in this merge request is much more fine tuned!

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 383300a895f..eb5340f4df0 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -949,6 +949,7 @@ no_ee_check:
 # GitLab Review apps
 review-build-cng:
   <<: *single-script-job
+  <<: *review-base
   variables:
     <<: *single-script-job-variables
     SCRIPT_NAME: trigger-build

mentioned in merge request !24575 (closed)

@gtsiolis And I just realized that this is a duplicate of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24575 and I am not sure why the job failed.

Unfortunately I can only look into it tomorrow.

@dbalexandre Sorry! I'll investigate tomorrow.

/assign @godfat

assigned to @godfat

Thanks, @godfat! No problem

No problem @godfat!

@godfat LGTM, I've retried the review-build-cng job but it isn't related to the change anyway.

@godfat Thank you, looks good to me!

assigned to @rymai

approved this merge request

enabled an automatic merge when the pipeline for f2d1aad2 succeeds

merged

mentioned in commit e67af069

mentioned in merge request !24590 (merged)