Skip to content

Only send one notification for failed remote mirror

Stan Hu requested to merge sh-suppress-duplicate-remote-mirror-notifications into master

Retries in Sidekiq and in the remote mirror scheduler can cause repeated attempts in quick succession if the sync fails. Each failure will then send an e-mail to all project maintainers, which can spam users unnecessarily.

Modify the logic to send one notification the first time the mirror fails by setting error_notification_sent to true and reset the flag after a successful sync.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56222

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9164

Edited by Stan Hu

Merge request reports