Skip to content

Add handling errors in a merge requests diff fetching process

Harry Kiselev requested to merge harrykiselev/gitlab-ce:failed-diff-fetching into master

What does this MR do?

This MR add a behaviour of handling errors on diff fetching process.

An issue #52685 (moved) describe a problem of handling errors on frontend when a response of diff fetching isn't successful.

In particular a diff loading spinner is visible if an error is returned.

Probably I take too much upon oneself about adding some new frontend logic without discussion here but I have solved this problem by:

  • hiding a diffs loading spinner;
  • moving a flash error from top of a page into the diff container;
  • adding a refetching diff process by clicking on a flash message;

Perhaps my path of resolving issue isn't correct but I think you will fix me here in this case 🙂

Thanks for a future review!

What are the relevant issue numbers?

#52685 (moved)

Does this MR meet the acceptance criteria?

Merge request reports