Skip to content

Switch use of Rack::Request to ActionDispatch::Request

Stan Hu requested to merge sh-switch-rack-request-to-actionpack into master

As mentioned in https://gitlab.com/gitlab-org/gitlab-ee/issues/9035#note_129093444, Rails 5 switched ActionDispatch::Request so that it no longer inherits Rack::Request directly. A middleware that uses Rack::Request to read the environment may see stale request parameters if another middleware modifies the environment via ActionDispatch::Request. To be safe, we should be using ActionDispatch::Request everywhere.

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9060

Edited by Stan Hu

Merge request reports