Skip to content

Revert "Add "none" syntax highlighting "color" scheme"

Fatih Acet requested to merge _acet-revert-none-syntax-theme into master

Reverts an accidentally merged MR.

Below is the retrospective of this accidental merge. Original can be found here.

I think we have a problem here. 😞

TL;DR: I accidentally merged this one without testing the latest version. I will revert this with another MR.

I was thinking git pull should update the branch with the latest changes in this MR but, in fact, it's a community contribution and when I first reviewed this MR I checked out a temporary branch with no upstream configured by following the instructions in MR widget.

When I do git pull to get the latest changes it didn't work but I didn't know that and tested the old version I tested a while ago.

Sadly, it looks with the latest commits, this feature is completely broken. I see the "None" theme as almost like "White" theme.

Right after merging this, I checked out to master and did a pull then that's how I realized it. I restarted my GDK several times and also asked @psimyn to test this in his local GDK, and turns out that this feature doesn't work.

I will revert this with another MR.

Merge request reports