The source project of this merge request has been removed.
Stop using HipChat in the ServicesController spec
What does this MR do?
We're planning to remove HipChat in 12.0: #52424 (closed)
I've got a WIP MR for it: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22223 - one of the problems thrown up by this MR is that the services controller uses the HipchatService
as an exemplar for its tests.
To fix this, I've migrated the tests from the HipChat service to the JIRA service. Merging this sooner than 12.0 means we don't have to worry about dealing with it later.
I've tried to avoid changing how the tests work in any detail, just 1:1 substituting HipchatService
for JiraService
.
What are the relevant issue numbers?
Related to #52424 (closed)
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated
-
Tests added for this feature/bug -
Conforms to the code review guidelines - [-] Conforms to the merge request performance guidelines
-
Conforms to the style guides - [-] Conforms to the database guides
- [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
- [-] Security reports checked/validated by reviewer