Skip to content

Update to bootstrap 4.1.3

Lukas Eipert requested to merge leipert-upgrade-bootstrap into master

What does this MR do?

Update bootstrap to 4.1.3. We previously had problems with one of their selectors (https://gitlab.com/gitlab-org/gitlab-ce/issues/51362), but I don't think they are going to remove it again from their CSS (as per: https://github.com/twbs/bootstrap/issues/26878)

Bootstrap < 4.1.2 is vulnerable to several XSS attacks, so I thought it might make sense to update and "revert the broken CSS selector" on our site.

Without the CSS fix (download icon) With the CSS fix
fix-without fix-with-adjusted-css

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports