Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !22954

Merged
Opened Nov 09, 2018 by Stan Hu@stanhuOwner

Make sure there's only one slash as path separator

  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 13

In Ruby 2.4, URI.join("http://test//", "a").to_s will remove the double slash, however it's not the case in Ruby 2.5. Using chomp should work better for the intention, as we're not trying to allow things like ../ or / paths resolution.

EE port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8084

Assignee
Assign to
Reviewer
Request review from
11.6
Milestone
11.6 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!22954
Source branch: sh-53180-append-path