Resolve "Navigating unresolved discussions on Merge Request page"
What does this MR do?
Updates logic to be able to navigate in discussions after we've introduced Incremental Rendering of Diff files.
Kapture_2018-11-03_at_21.34.32
How to test
An example of a test script to test locally:
- Import https://gitlab.com/leipert/test-project into your local env
- Open an MR with ~13,000 lines added.
- Go the the MR Changes tab, start a discussion on one file at the very top.
- Scroll down until you see collapsed files, expand and start a discussion on any one of its lines.
- do that a few more times.
- Reload the page.
- Try navigating discussions on Discussion tab and Changes tab.
Behaviour on collapsed files: when clicked on next discussion, browser scrolls to file, shows loading spinner, when loading is complete, jump to discussion.
What are the relevant issue numbers?
Closes #51122 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides
Edited by André Luís