Skip to content

Also count specs in new files in Danger check

Sean McGivern requested to merge consider-added-specs-in-danger-checks into master

We have a Danger check that warns if you made changes in app/ but not in spec/. However, this only checked for changed files - not new files. If you added an app file with no specs, it wouldn't warn; and it would warn erroneously if you added a missing spec file while changing a file in app/.

See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8050#note_111150107 for an example of the latter failure, which was a little strange at first.

Merge request reports