Skip to content

Remove auto deactivation when failed to create a pipeline via pipeline schedules

Shinya Maeda requested to merge ignore-failed-pipeline-creation-on-pipeline-schedule into master

What does this MR do?

Currently, when a pipeline schedule failed to create a pipeline by some reason, the pipeline schedule will be deactivated automatically. Althoguh it seems this implementation backfired to some users that sometimes innocent pipeline schedules were deactivated, even though it had enough permission.

Pipeline schedule should not be deactivated by the single point of failure, as still, there is a chance to be recovered in the future. Users should deactivate it by themselves or delegate the ownership to other ones.

What are the relevant issue numbers?

Close https://gitlab.com/gitlab-org/gitlab-ce/issues/41231

/cc @grzesiek @erushton

Does this MR meet the acceptance criteria?

Edited by Shinya Maeda

Merge request reports