Resolve "Merge request buttons spacing incorrect"
What does this MR do?
This MR fixes the spacing issue on MRs, refer to the picture below:
Before | After |
---|---|
![]() |
![]() |
What are the relevant issue numbers?
Closes #48494 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
marked the checklist item Conforms to the merge request performance guidelines as completed
marked the checklist item Conforms to the style guides as completed
@psimyn could you please have a look at this MR?
assigned to @psimyn
1 Error 7e91c27d: The commit body should not contain more than 72 characters per line 1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
Danger LGTM @jerasmus@fatihacet can you please merge?
assigned to @fatihacet
mentioned in commit ecbcda22
mentioned in issue gitlab-org/release/tasks#515 (closed)
added devopscreate label