Incorporates Kubernetes Namespace into Cluster's flow
What does this MR do?
Incorporates Clusters::KubernetesNamespace
into clusters flow:
-
Create the namespace/service account in GCP Kubernetes, when creating a cluster -
Create the namespace/service account in GCP Kubernetes, when adding a cluster -
Create the namespace/service account in GCP Kubernetes, when modifying namespace -
Replace KUBE_TOKEN
andKUBECONFIG
(passed to CI) with new credentials
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/51716
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - [-] Documentation created/updated
-
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides - [-] Conforms to the database guides
Manual QA
ABAC Cluster
-
Add a Cluster -
Check namespace/service account were created on kubernetes side -
Install applications -
Run AutoDevOps pipeline
RBAC Cluster
Creating cluster
-
Create Cluster -
Check namespace/service account were created on kubernetes side -
Install applications -
Run AutoDevOps pipeline
Auto DevOps for ABAC
-
Switch to master branch -
Create a cluster ABAC -
Switch to this branch, restart GDK -
Run Auto DevOps pipeline
Auto DevOps for RBAC
-
Switch to master branch -
Create a cluster -
Switch to this branch, restart GDK -
Run Auto DevOps pipeline
Merge request reports
Activity
assigned to @tkuah
1 Error 924ad021: The commit body should not contain more than 72 characters per line 1 Warning This merge request is quite big (more than 1214 lines changed), please consider splitting it into multiple merge requests. Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- eb3ce7c2 - Create namespace upon cluster creation/addition
added database label
- Resolved by Mayra Cabrera
marked as a Work In Progress from 063003de
For reference - runner currently fails like this when provided it fails to connect to a previously configured cluster
Running with gitlab-runner 10.3.0 (5cf5e19a) on runner-gitlab-runner-76cd6bdfd6-ts8f6 (160b7484) Using Kubernetes namespace: gitlab-managed-apps Using Kubernetes executor with image docker:stable-git ... Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending Waiting for pod gitlab-managed-apps/runner-160b7484-project-9-concurrent-0fsrbx to be running, status is Pending ERROR: Job failed (system failure): timedout waiting for pod to start
assigned to @mayra-cabrera
mentioned in issue #51716 (closed)
added 635 commits
-
d72817dc...1540d51a - 632 commits from branch
master
- 91ef8b2b - Allow namespace for a project / cluster to persist
- 3905012b - Create namespace upon cluster creation/addition
- 7e120401 - Extract actual_namespace logic to service
Toggle commit list-
d72817dc...1540d51a - 632 commits from branch
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Tests added for this feature/bug as completed
changed milestone to %11.5
- Resolved by Mayra Cabrera
When cluster is already created and namespace has been created on Kubernetes cluster side, what should we do if the user edits the cluster and changes the "namespace"?
Should sync also Kubernetes cluster? (create new namespace and service account). My instinct says yes, but not sure if I'm missing something
Edited by Mayra Cabrera
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera