Change markdown header tab anchor links to buttons
What does this MR do?
Changes markdown header tab anchor links to buttons. (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21988#note_105636972)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
added 1 commit
- 1ace4b99 - Add link component to markdown header component
marked the checklist item Changelog entry added, if necessary as completed
- Resolved by George Tsiolis
mentioned in merge request !21989 (merged)
added Community contribution ~8006023 labels
This should be ready to merge. /cc @ClemMakesApps
Edited by George Tsiolisadded frontend label
changed milestone to %11.4
assigned to @ClemMakesApps
- Resolved by Clement Ho
- Resolved by George Tsiolis
assigned to @gtsiolis
mentioned in merge request !21986 (merged)
mentioned in merge request !21987 (merged)
mentioned in merge request !22032 (merged)
added 110 commits
-
1ace4b99...c9375e63 - 109 commits from branch
gitlab-org:master
- 9ea45f17 - Add link component to markdown header component
-
1ace4b99...c9375e63 - 109 commits from branch
added 12 commits
-
cde9f82b...de21a2b5 - 10 commits from branch
gitlab-org:master
- f8d63142 - Add link component to markdown header component
- 0d1fd3ff - Replace markdown header tab anchor links to buttons
-
cde9f82b...de21a2b5 - 10 commits from branch
added 1 commit
- 017a66f7 - Change markdown header tab anchor links to buttons
added 1 commit
- a9193f04 - Change markdown header tab anchor links to buttons
added 1 commit
- 515a2b2d - Change markdown header tab anchor links to buttons
added 1 commit
- a170fdea - Update specs for markdown header tab buttons
added 15 commits
-
a170fdea...49e08372 - 12 commits from branch
gitlab-org:master
- 295b6c85 - Add link component to markdown header component
- 639b66da - Change markdown header tab anchor links to buttons
- b5709407 - Update specs for markdown header tab buttons
Toggle commit list-
a170fdea...49e08372 - 12 commits from branch
- Resolved by George Tsiolis
- Resolved by George Tsiolis
- Resolved by George Tsiolis
- Resolved by George Tsiolis
added 24 commits
-
b5709407...bf37ff07 - 21 commits from branch
gitlab-org:master
- a827768d - Add link component to markdown header component
- bc1a09f9 - Change markdown header tab anchor links to buttons
- 17c5f49c - Update specs for markdown header tab buttons
Toggle commit list-
b5709407...bf37ff07 - 21 commits from branch
added 1 commit
- 0c553eb5 - Update specs for markdown header tab buttons
- Resolved by George Tsiolis
added 1 commit
- 0eb0b6aa - Update specs for markdown header tab buttons
added 19 commits
-
0eb0b6aa...9ab59100 - 16 commits from branch
gitlab-org:master
- 6a02dfe1 - Add link component to markdown header component
- 9dbdaf87 - Change markdown header tab anchor links to buttons
- c3bcb115 - Update specs for markdown header tab buttons
Toggle commit list-
0eb0b6aa...9ab59100 - 16 commits from branch
assigned to @ClemMakesApps
added 431 commits
-
c3bcb115...c3389c80 - 428 commits from branch
gitlab-org:master
- d413ff06 - Add link component to markdown header component
- 17469170 - Change markdown header tab anchor links to buttons
- 944f1b34 - Update specs for markdown header tab buttons
Toggle commit list-
c3bcb115...c3389c80 - 428 commits from branch
The vue code looks good to me, @annabeldunstone can you review the UX and the css? Thanks
assigned to @annabeldunstone
I was out for a couple days so currently trying to catch up on everything. Changing this to 11.5 since the 11.4 merge window is closed, but will get to this hopefully tomorrow. Thanks @gtsiolis!
changed milestone to %11.5
No problem @annabeldunstone! This is low priority.
Edited by George Tsiolis- Resolved by Annabel Dunstone Gray
Thanks @gtsiolis! Just a couple notes
assigned to @gtsiolis
added 349 commits
-
8600eaf0...d87e88a6 - 343 commits from branch
gitlab-org:master
- 38063fbd - Add link component to markdown header component
- a74ba2ed - Change markdown header tab anchor links to buttons
- 64ed2da1 - Update specs for markdown header tab buttons
- 21fc6dc7 - Restore markdown header tab layout
- cc3ecc4a - Restore theme based border for md header tabs
- a4386883 - Add flex direction in md header tabs
Toggle commit list-
8600eaf0...d87e88a6 - 343 commits from branch
@annabeldunstone could you take another look when you're free? I've also changed the header tabs (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21988#note_108460983) in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21988/diffs?commit_id=a43868836ddb689813ab27c296e6a7ef8a7f9954.
- Resolved by Annabel Dunstone Gray
Also, added EE port in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8001.
assigned to @annabeldunstone
LGTM! Thanks @gtsiolis
mentioned in commit 6b70b772
Many thanks @annabeldunstone!
mentioned in merge request !22565 (merged)
mentioned in issue #53105 (closed)
mentioned in merge request !22449 (merged)
mentioned in issue gitlab-org/release/tasks#515 (closed)