Skip to content
Snippets Groups Projects

Change markdown header tab anchor links to buttons

All threads resolved!

What does this MR do?

Changes markdown header tab anchor links to buttons. (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21988#note_105636972)

Does this MR meet the acceptance criteria?

Edited by George Tsiolis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • George Tsiolis mentioned in merge request !21989 (merged)

    mentioned in merge request !21989 (merged)

  • added Community contribution ~8006023 labels

  • George Tsiolis resolved all discussions

    resolved all discussions

  • Author Developer

    This should be ready to merge. /cc @ClemMakesApps

    Edited by George Tsiolis
  • added frontend label

  • Rémy Coutable changed milestone to %11.4

    changed milestone to %11.4

  • assigned to @gtsiolis

  • George Tsiolis mentioned in merge request !21986 (merged)

    mentioned in merge request !21986 (merged)

  • George Tsiolis mentioned in merge request !21987 (merged)

    mentioned in merge request !21987 (merged)

  • George Tsiolis mentioned in merge request !22032 (merged)

    mentioned in merge request !22032 (merged)

  • George Tsiolis added 110 commits

    added 110 commits

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    Compare with previous version

  • George Tsiolis added 12 commits

    added 12 commits

    • cde9f82b...de21a2b5 - 10 commits from branch gitlab-org:master
    • f8d63142 - Add link component to markdown header component
    • 0d1fd3ff - Replace markdown header tab anchor links to buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • 017a66f7 - Change markdown header tab anchor links to buttons

    Compare with previous version

  • George Tsiolis changed title from Add link component to markdown header component to Change markdown header tab anchor links to buttons

    changed title from Add link component to markdown header component to Change markdown header tab anchor links to buttons

  • George Tsiolis changed the description

    changed the description

  • George Tsiolis added 1 commit

    added 1 commit

    • a9193f04 - Change markdown header tab anchor links to buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • 515a2b2d - Change markdown header tab anchor links to buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • a170fdea - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 15 commits

    added 15 commits

    • a170fdea...49e08372 - 12 commits from branch gitlab-org:master
    • 295b6c85 - Add link component to markdown header component
    • 639b66da - Change markdown header tab anchor links to buttons
    • b5709407 - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 24 commits

    added 24 commits

    • b5709407...bf37ff07 - 21 commits from branch gitlab-org:master
    • a827768d - Add link component to markdown header component
    • bc1a09f9 - Change markdown header tab anchor links to buttons
    • 17c5f49c - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • 0c553eb5 - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • 0eb0b6aa - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 19 commits

    added 19 commits

    • 0eb0b6aa...9ab59100 - 16 commits from branch gitlab-org:master
    • 6a02dfe1 - Add link component to markdown header component
    • 9dbdaf87 - Change markdown header tab anchor links to buttons
    • c3bcb115 - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 431 commits

    added 431 commits

    • c3bcb115...c3389c80 - 428 commits from branch gitlab-org:master
    • d413ff06 - Add link component to markdown header component
    • 17469170 - Change markdown header tab anchor links to buttons
    • 944f1b34 - Update specs for markdown header tab buttons

    Compare with previous version

  • George Tsiolis added 1 commit

    added 1 commit

    • 8600eaf0 - Restore markdown header tab layout

    Compare with previous version

  • The vue code looks good to me, @annabeldunstone can you review the UX and the css? Thanks

  • I was out for a couple days so currently trying to catch up on everything. Changing this to 11.5 since the 11.4 merge window is closed, but will get to this hopefully tomorrow. Thanks @gtsiolis!

  • changed milestone to %11.5

  • Author Developer

    No problem @annabeldunstone! This is low priority. :mushroom:

    Edited by George Tsiolis
  • The tabs should look like this on mobile On this branch they look like this
    Screen_Shot_2018-10-12_at_1.13.33_PM Screen_Shot_2018-10-12_at_1.15.21_PM
  • Thanks @gtsiolis! Just a couple notes

  • George Tsiolis added 349 commits

    added 349 commits

    • 8600eaf0...d87e88a6 - 343 commits from branch gitlab-org:master
    • 38063fbd - Add link component to markdown header component
    • a74ba2ed - Change markdown header tab anchor links to buttons
    • 64ed2da1 - Update specs for markdown header tab buttons
    • 21fc6dc7 - Restore markdown header tab layout
    • cc3ecc4a - Restore theme based border for md header tabs
    • a4386883 - Add flex direction in md header tabs

    Compare with previous version

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • Annabel Dunstone Gray resolved all discussions

    resolved all discussions

  • mentioned in commit 6b70b772

  • Author Developer

    Many thanks @annabeldunstone! :pray:

  • George Tsiolis mentioned in merge request !22565 (merged)

    mentioned in merge request !22565 (merged)

  • mentioned in issue #53105 (closed)

  • George Tsiolis mentioned in merge request !22449 (merged)

    mentioned in merge request !22449 (merged)

  • Please register or sign in to reply
    Loading