Rename squash before merge vue component
What does this MR do?
- Renames squash before merge vue component.
- Deletes unnecessary relevant
.js
file.
What are the relevant issue numbers?
This is a follow-up from !18956 (merged).
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides
Merge request reports
Activity
marked the checklist item Changelog entry added, if necessary as completed
I really missed convention changes! I've also added the EE port in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7449.
added Community contribution label
@kushalpandya Could you please review? Thanks!
added Plan [DEPRECATED] backstage [DEPRECATED] frontend merge requests labels
changed milestone to %11.4
assigned to @kushalpandya
@gtsiolis I didn't get the intention behind this file rename, is there any issue or discussion that I can refer to behind this decision? As I can see that every component within
app/assets/javascripts/vue_merge_request_widget/components/states
hasmr_widget_
prefix to it, so having just one component not have that prefix feels out of place to me.@fatihacet Can you chime in here please?
@kushalpandya some of the component names in the
vue_merge_request_widget
folder have been changed to remove themr_widget_
prefix in the past during the ongoing effort in #34371 (moved) regarding FE performance. This has been discussed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17533#note_62041970 and there's an issue regarding this (#44261 (moved)). The initial purpose of this merge request was to remove the redundant.js
file. Let me know if something has changed regarding direction.Edited by George Tsiolisassigned to @iamphill
Indeed, the total work done on the merge request widget has been incredible so far AFAIK! Thanks @kushalpandya! Some prefixes could or should probably stay as is at least for now, but I think this is an evolving process (see #51855 (moved)).
Edited by George Tsiolismentioned in commit c052f5a9
mentioned in issue gitlab-org/release/tasks#464 (closed)
added devopsplan label