Skip to content

Resolve "Provide NullStore for RequestStore"

Michael Kozono requested to merge mk/improve-usage-of-request-store into master

What does this MR do?

Makes it easier and safer to use RequestStore because you don't need to check RequestStore.active? before using it. You just have to use Gitlab::SafeRequestStore instead.

For example, one consequence of forgetting to do this leads to state being leaked across tests.

What are the relevant issue numbers?

Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/51718

Does this MR meet the acceptance criteria?

Edited by Yorick Peterse

Merge request reports