Skip to content

Fix route deprecation warnings in rails 5

Jan Provaznik requested to merge rails5-route-warnings into master

What does this MR do?

Rails 5 deprecated usage of some routing options. This patch fixes following warnings from https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/94389380:

  • DEPRECATION WARNING: #controller with options is deprecated. If you need to pass more options than the controller name use #scope. (called from instance_eval at /builds/gitlab-org/gitlab-ee/config/initializers/routing_draw.rb:5)

  • DEPRECATION WARNING: Using a dynamic :action segment in a route is deprecated and will be removed in Rails 5.2. (called from block (2 levels) in at /builds/gitlab-org/gitlab-ee/config/routes.rb:37)

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Jan Provaznik

Merge request reports